Opened 6 years ago

Closed 4 years ago

#1483 closed defect (done)

The default constructor for DataRow should not be public

Reported by: abeham Owned by: gkronber
Priority: high Milestone: HeuristicLab 3.3.9
Component: Analysis Version: 3.3.3
Keywords: Cc:

Description

The view accesses all series in the chart by the name of the DataRow. If a DataRow has no name, its series can't be accessed.

Also a check should be made so that DataRow.Name cannot be set to NullOrEmpty

Change History (6)

comment:1 Changed 4 years ago by gkronber

  • Owner changed from swagner to gkronber
  • Priority changed from medium to high
  • Status changed from new to accepted

comment:2 Changed 4 years ago by gkronber

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.9

comment:3 Changed 4 years ago by gkronber

r9740: removed parameterless constructor from DataRow and added a check for IsNullOrEmpty.

comment:4 Changed 4 years ago by gkronber

  • Owner changed from gkronber to abeham
  • Status changed from accepted to reviewing

comment:5 Changed 4 years ago by abeham

  • Owner changed from abeham to gkronber
  • Status changed from reviewing to readytorelease

The change looks good.

comment:6 Changed 4 years ago by gkronber

  • Resolution set to done
  • Status changed from readytorelease to closed

r9829: merged r9740 into the stable branch

Note: See TracTickets for help on using tickets.