Opened 6 years ago

Closed 4 years ago

#1270 closed enhancement (done)

Implement representation of symbolic expressions in Smalltalk syntax

Reported by: swinkler Owned by: gkronber
Priority: low Milestone: HeuristicLab 3.3.9
Component: Encodings.SymbolicExpressionTreeEncoding Version: branch
Keywords: Cc:

Description


Change History (44)

comment:1 Changed 6 years ago by swinkler

  • Status changed from new to accepted

comment:2 Changed 6 years ago by swinkler

  • Version changed from 3.3.3 to branch

comment:3 Changed 6 years ago by swinkler

Created branch in r4803.

comment:4 Changed 6 years ago by swinkler

Corrected references and post-build events in r4804.

comment:5 Changed 6 years ago by swinkler

  • Cc swagner mkommend added

As discussed with swagner and mkommend, we will implement an interface for tree formatters and a view in which the user is able to choose from all available formatters. We will also create a new project for all tree formatters except the default formatter (which stays in the SymbolicExpressionTreeEncoding project).

comment:6 Changed 6 years ago by swinkler

Added interface and founded new project for formatters in r4820.

comment:7 Changed 6 years ago by gkronber

I think it might be more appropriate to have formatters in problem plugins as the semantics of symbols are actually problem specific. In the encoding only terminal and non-terminal symbols can be distinguished.

Last edited 6 years ago by gkronber (previous) (diff)

comment:8 Changed 6 years ago by gkronber

Please implement the formatter in the new folder called "Formatters" in the plugin "HeuristicLab.Problems.DataAnalysis".

Create the folder in this directory: https://dev.heuristiclab.com/trac/hl/core/browser/trunk/sources/HeuristicLab.Problems.DataAnalysis/3.3/Symbolic

comment:9 Changed 6 years ago by swinkler

Worked on Smalltalk representation in r4820, r4821, r4822, and r4823.

comment:10 Changed 6 years ago by swinkler

Renamed branch in r4829.

comment:11 Changed 6 years ago by swinkler

Worked on the display of results of formatters in r4840:

  • Renamed solution in formatters branch
  • implemented view for display of symbolic expression trees as strings depending on the chosen formatter

comment:12 Changed 6 years ago by swinkler

Improved management of formatters in view for display of symbolic expression trees as strings as discussed with mkommend in r4842.

comment:13 Changed 6 years ago by swinkler

Minor update regarding files that should not be under version control in r4843 and r4844.

comment:14 Changed 6 years ago by swinkler

Removed obsolete project for symbolic expression tree formatters and (re-)added DataAnalysis project in r4858. Minor update in r4859.

comment:15 Changed 6 years ago by swinkler

Added Smalltalk formatter in r4861.

comment:16 Changed 6 years ago by swinkler

Added first complete version of Smalltalk formatter in r4868.

comment:17 Changed 6 years ago by swinkler

Fixed bugs in r4869.

comment:18 Changed 6 years ago by gkronber

  • Milestone changed from HeuristicLab x.x.x to HeuristicLab 3.3.3

comment:19 Changed 6 years ago by gkronber

r4900:

  • Added string formatters for GraphViz and LaTeX formats.
  • Set svn:ignore properties
Last edited 6 years ago by gkronber (previous) (diff)

comment:20 Changed 6 years ago by swinkler

Removed attributes Storable and StorableClass from tree formatters in r4906.

Last edited 6 years ago by swinkler (previous) (diff)

comment:21 Changed 6 years ago by swinkler

Corrected name and description of Graphviz formatter in r4966.

comment:22 Changed 6 years ago by gkronber

Added build.cmd script, and adapted .frame files for new release with r4967.

comment:23 Changed 6 years ago by gkronber

Moved graphviz formatter into symbolic expression tree encoding plugin with r4968.

comment:24 Changed 6 years ago by swinkler

Updated projects in exporters branch reacting on recent changes in the trunk (.NET 4.0, changes in interface of dataset) in r5180.

comment:25 Changed 6 years ago by gkronber

  • Owner changed from swinkler to gkronber
  • Status changed from accepted to reviewing

comment:26 Changed 6 years ago by swagner

  • Milestone changed from HeuristicLab 3.3.3 to HeuristicLab x.x.x

comment:27 Changed 6 years ago by gkronber

  • Status changed from reviewing to assigned

comment:28 Changed 4 years ago by gkronber

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.9
  • Priority changed from medium to low

Parts of the changes tracked in this ticket have already been released. The remaining changes should be integrated into the trunk to finally close this ticket.

comment:29 Changed 4 years ago by gkronber

  • Status changed from assigned to accepted

comment:30 Changed 4 years ago by gkronber

r9647: copied smalltalk formatter from branch

comment:31 Changed 4 years ago by gkronber

r9648: copied GraphViz formatter from branch

comment:32 Changed 4 years ago by gkronber

r9649: fixed compile errors in Smalltalk and GraphViz formatters

comment:33 Changed 4 years ago by gkronber

  • GraphViz exporter works fine.
  • Semantic correctness of Smalltalk exporter must be checked.

comment:34 Changed 4 years ago by gkronber

r9794: adapted smalltalk exporter to match interpreter semantics

comment:35 Changed 4 years ago by gkronber

r9795: deleted branch for data-analysis extensions as the smalltalk, MATLAB and GraphViz exporters have been integrated into the trunk

comment:36 Changed 4 years ago by gkronber

  • Owner changed from gkronber to mkommend
  • Status changed from accepted to reviewing

comment:37 Changed 4 years ago by mkommend

  • Owner changed from mkommend to gkronber
  • Status changed from reviewing to assigned

Reviewed GraphViz and Smalltalk formatter for symbolic expression trees. I have tested the GraphViz formatter with an online dot engine and it seems to work fine. However, I could not test the Smalltalk exporter.

Review comments:

  • The default formatter should be used when the textual representation of a model is opened.
  • The namespace of the GraphViz formatter does not adhere to the coding standards.
  • Remove unused using in the GraphViz formatter.
  • The namespace of the Smalltalk formatter is completely wrong.
  • The Smalltalk formatter does not support all available symbols.

comment:38 Changed 4 years ago by gkronber

r9821: made changes as suggested in the review comments

  • initially select default string formatter in the symbolic expression view
  • renamed smalltalk formatter and fixed the namespace
  • fixed namespace of GraphViz formatter
  • removed unused usings

comment:39 Changed 4 years ago by gkronber

  • Cc swagner mkommend removed
  • Owner changed from gkronber to mkommend
  • Status changed from assigned to reviewing

comment:40 Changed 4 years ago by mkommend

  • Owner changed from mkommend to gkronber
  • Status changed from reviewing to readytorelease

comment:41 Changed 4 years ago by gkronber

r9862: merged r9647:9649, r9794:9795, r9821 from trunk to stable branch

comment:42 Changed 4 years ago by gkronber

r9863: fixed copyright year

comment:43 Changed 4 years ago by gkronber

r9864: merged r9863 from trunk to stable branch

comment:44 Changed 4 years ago by gkronber

  • Resolution set to done
  • Status changed from readytorelease to closed
Note: See TracTickets for help on using tickets.