Opened 7 years ago

Closed 11 months ago

#1235 closed enhancement (done)

Context menu to close tabs/views

Reported by: cfischer Owned by: mkommend
Priority: low Milestone: HeuristicLab 3.3.14
Component: MainForm.WindowsForms Version: 3.3.13
Keywords: Cc:

Description (last modified by pfleck)

Possible context menu entries:

  • close tab
  • clone tab
  • more?

Change History (15)

comment:1 Changed 6 years ago by swagner

  • Milestone set to HeuristicLab x.x.x
  • Version changed from 3.3.2 to 3.3.1

comment:2 Changed 4 years ago by gkronber

  • Priority changed from lowest to low

comment:3 Changed 17 months ago by mkommend

  • Owner changed from mkommend to pfleck
  • Status changed from new to assigned

comment:4 Changed 17 months ago by pfleck

  • Description modified (diff)
  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.14
  • Status changed from assigned to accepted
  • Version changed from 3.3.1 to 3.3.13

comment:5 Changed 17 months ago by pfleck

r13458 Added a context menu to the DockForm to close (this, all, all but this) and clone the item of the current tab.

comment:6 Changed 16 months ago by pfleck

  • Owner changed from pfleck to mkommend
  • Status changed from accepted to reviewing

comment:7 Changed 15 months ago by mkommend

  • Owner changed from mkommend to pfleck
  • Status changed from reviewing to assigned

Review comments

  • Clone menu item should be disabled if the view is no IContentView or the content is not deep cloneable.
  • Create Copy should not be possible when an algorithm is running (View is locked).
  • The clone should be displayed using the same view currently displaying the content.
  • There are some problems when closing views with the context menu:
    • NullPointerException when the view is floating (close all | close all but this).
    • View is docked to the left -> only the docked view is close (close all).
    • Maybe we should only show the close menu entry if the view is not a tab page.
  • DockForm Line 127: ToList is unnecessary.

comment:8 Changed 15 months ago by pfleck

  • Status changed from assigned to accepted

comment:9 Changed 15 months ago by pfleck

r13614

  • Clone menuitem is enabled only if view is not locked and content is deep cloneable.
  • Cloned item shows in same view as the original item.
  • Fixed possible NullReferenceException.
  • Fixed inconsistency which views were closed on "close all (but this)".

comment:10 Changed 15 months ago by pfleck

  • Owner changed from pfleck to mkommend
  • Status changed from accepted to reviewing

comment:11 Changed 14 months ago by mkommend

r13627: Changed access modifier of MainForm.GetForm(view) from internal to protected internal to enable more customization in derived mainforms.

comment:12 Changed 14 months ago by pfleck

r13628 Added an AllowContexMenu property in the DockingMainForm to be able to enable/disable the context menu. Changing the property will only affect DockForms after the change.

comment:13 Changed 14 months ago by mkommend

  • Status changed from reviewing to readytorelease

Reviewed r13458, r13614, r13627 and r13628.

comment:14 Changed 11 months ago by mkommend

r13883: Merged r13458,r13614,r13627,r13628 into stable.

comment:15 Changed 11 months ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed
Note: See TracTickets for help on using tickets.