Opened 7 years ago

Closed 4 years ago

#1099 closed task (done)

Create unit tests for NamedItems

Reported by: mkommend Owned by: mkommend
Priority: high Milestone: HeuristicLab 3.3.9
Component: Tests Version: 3.3
Keywords: Cc:

Description (last modified by abeham)

Every NamedItem must have a name specified when it is created by its default ctor. If no name is specified and a user clicks in the name textbox, the error provider is triggered and it is impossible to leave the control. This behavior should be checked by a UnitTest.

Change History (20)

comment:1 Changed 7 years ago by swagner

  • Component changed from Core to Tests

comment:2 Changed 7 years ago by swagner

  • Summary changed from Create UnitTests for NamedItems to Create unit tests for NamedItems

comment:3 Changed 4 years ago by gkronber

  • Priority changed from medium to high

comment:4 Changed 4 years ago by mkommend

  • Owner changed from swagner to mkommend
  • Status changed from new to accepted

comment:5 Changed 4 years ago by mkommend

r9816: Added default name for DataTable and ScatterPlotDatarow when created with the default ctor.

comment:6 Changed 4 years ago by mkommend

r9817: Added NamedItemTest.

comment:7 Changed 4 years ago by mkommend

  • Owner changed from mkommend to ascheibe
  • Status changed from accepted to assigned

Please adapt the Hive classes, which do not have a name set.

comment:8 Changed 4 years ago by ascheibe

r9819 adapted Hive NamedItems

comment:9 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to mkommend

comment:10 Changed 4 years ago by mkommend

  • Status changed from assigned to accepted

r9820: Corrected namespace of NamedItemTest and added it to the basic test list.

comment:11 Changed 4 years ago by mkommend

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.9
  • Owner changed from mkommend to abeham
  • Status changed from accepted to reviewing

comment:12 Changed 4 years ago by abeham

  • Description modified (diff)
  • Owner changed from abeham to mkommend
  • Status changed from reviewing to readytorelease

Change looks good. I removed the outdated unit test reference parts of the ticket description.

comment:13 Changed 4 years ago by jkarder

  • Owner changed from mkommend to jkarder
  • Status changed from readytorelease to assigned

The MetaOpt branch build failed because of the NamedItemTest. I will commit the necessary changes here.

Last edited 4 years ago by jkarder (previous) (diff)

comment:14 Changed 4 years ago by jkarder

r9823: adapted MetaOpt NamedItems

comment:15 Changed 4 years ago by jkarder

  • Owner changed from jkarder to mkommend
  • Status changed from assigned to reviewing

comment:16 Changed 4 years ago by mkommend

  • Owner changed from mkommend to jkarder
  • Status changed from reviewing to assigned

comment:17 Changed 4 years ago by jkarder

  • Status changed from assigned to accepted

comment:18 Changed 4 years ago by jkarder

  • Owner changed from jkarder to mkommend
  • Status changed from accepted to reviewing

r9827:

  • adapted MetaOpt NamedItems once more
    • gave more meaningful names to some items
    • removed unreferenced default ctors
    • changed access modifiers

comment:19 Changed 4 years ago by mkommend

  • Status changed from reviewing to readytorelease

comment:20 Changed 4 years ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed

r9886: Merged changesets for named item unit test into the stable branch.

Note: See TracTickets for help on using tickets.