Changeset 11867

Timestamp:

02/03/15 13:50:25 (9 years ago)

Author:

mkommend

Message:

#2295: Merged r11782 and r11784 into stable.

Location:

stable

Files:

• . (modified) (1 prop)
• HeuristicLab.Tests (modified) (1 prop)
• HeuristicLab.Tests/HeuristicLab-3.3/DeepCloneableCloningTest.cs (modified) (2 diffs)

stable/HeuristicLab.Tests/HeuristicLab-3.3/DeepCloneableCloningTest.cs

@@ -126 +126 @@
     private bool ProcessEqualObjects(IDeepCloneable item, IEnumerable<object> intersections) {
       bool success = true;
-      TestContext.WriteLine(Environment.NewLine + item.GetType().FullName + ":");
+      bool headerWritten = false;
+
       foreach (object o in intersections) {
         string typeName = o.GetType().FullName;
@@ -133 +134 @@
         } else if (o is IDeepCloneable) {
           string info = (o is IItem) ? ((IItem)o).ItemName + ((o is INamedItem) ? ", " + ((INamedItem)o).Name : String.Empty) : String.Empty;
+          if (!headerWritten) {
+            TestContext.WriteLine(Environment.NewLine + item.GetType().FullName + ":");
+            headerWritten = true;
+          }
           TestContext.WriteLine("POTENTIAL ERROR! A DEEPCLONEABLE WAS NOT DEEP CLONED (" + info + "): " + typeName);
           success = false;
-        } else
+        } else {
+          Array array = o as Array;
+          if (array != null && array.Length == 0) continue; //arrays of length 0 are used inside empty collections
+          if (!headerWritten) {
+            TestContext.WriteLine(Environment.NewLine + item.GetType().FullName + ":");
+            headerWritten = true;
+          }
           TestContext.WriteLine("WARNING: An object of type " + typeName + " is referenced in the original and in the clone.");
+        }
       }
       return success;