Ticket #2239: VariableStoreView.cs.patch

3.3/VariableStoreView.cs

@@ -41 +41 @@
   public partial class VariableStoreView : AsynchronousContentView {
     protected Dictionary<string, ListViewItem> itemListViewItemMapping;
     protected TypeSelectorDialog typeSelectorDialog;
+    private readonly Dictionary<Type, bool> serializableTypes;
     protected bool validDragOperation;
 
     public new VariableStore Content {
@@ -55 +56 @@
     public VariableStoreView() {
       InitializeComponent();
       itemListViewItemMapping = new Dictionary<string, ListViewItem>();
+      serializableTypes = new Dictionary<Type, bool>();
       variableListView.SmallImageList.Images.AddRange(new Image[] {
         HeuristicLab.Common.Resources.VSImageLibrary.Error,
         HeuristicLab.Common.Resources.VSImageLibrary.Object,
@@ -127 +129 @@
       if (typeSelectorDialog.ShowDialog(this) == DialogResult.OK) {
         try {
           return (object)typeSelectorDialog.TypeSelector.CreateInstanceOfSelectedType();
-        } catch (Exception ex) {
+        }
+        catch (Exception ex) {
           ErrorHandling.ShowErrorDialog(this, ex);
         }
       }
@@ -411 +414 @@
     }
 
     private bool IsSerializable(KeyValuePair<string, object> variable) {
+      var type = variable.Value.GetType();
+      if (serializableTypes.ContainsKey(type))
+        return serializableTypes[type];
+
       var ser = new Serializer(variable, ConfigurationService.Instance.GetDefaultConfig(new XmlFormat()), "ROOT", true);
       try {
-        return ser.Count() > 0;
-      } catch (PersistenceException) {
+        bool serializable = ser.Count() > 0;
+        serializableTypes[type] = serializable;
+        return serializable;
+      }
+      catch (PersistenceException) {
+        serializableTypes[type] = false;
         return false;
       }
     }